Rename grid desktop class for consistency #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
kmeleta
reviewed
Feb 25, 2022
ghost
added
the
sofiamatulis
force-pushed
the
grid-rename-desktop
branch
from
0fdd17c
to
9a9e0cf
Compare
ludoboludo
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Updated all
grid--full-widthclasses to be namedgrid--{{ section.settings.columns_desktop }}-col-desktop. Desktop grid settings should still work when 1 column is selectedWhy are these changes introduced?
For better consistency in class naming on desktop and mobile and less if statements and lines of code
What approach did you take?
Updated the naming when the column selection is of 1 for desktop
Testing steps/scenarios
Test all of these sections with 1 column on desktop (grid setting):
Demo links
Checklist