Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update product-media.liquid #1667

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update product-media.liquid #1667

wants to merge 1 commit into from

Conversation

msyyn
Copy link

@msyyn msyyn commented May 6, 2022

PR Summary:
XR button for product media now uses "title" as the value of title attribute. This PR changes title value to product title as seen on Shopify's documentation:
https://shopify.dev/themes/product-merchandising/media/support-media#launch-the-display-with-a-button

Why are these changes introduced?
Because it makes sense

What approach did you take?
Common sense

Other considerations

Testing steps/scenarios

  • Go to any product page that has 3D model as product media and use browser's inspect element to see if XR button's data-shopify-title attribute equals to product's title instead of "title".

Checklist

@ghost ghost added the cla-needed label May 6, 2022
@LucasLacerdaUX LucasLacerdaUX self-requested a review May 16, 2022 14:42
Copy link
Contributor

@ludoboludo ludoboludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @msyyn 👋

Thanks for taking the time to create this fix and participate in making the theme better 👍

I was just checking the changes and I was wondering if you could also make the same change in the product-thumbnail.liquid file ? 🙂

I can re review when it's done 👍

@bacounts
Copy link

bacounts commented Jul 6, 2022

@msyyn, any update on this PR's merge?

@msyyn
Copy link
Author

msyyn commented Jul 6, 2022

Feel free to merge this fix if you think it makes sense, product thumbnail can be checked by someone else:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants