Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update spacing below product media #1689

Merged
merged 4 commits into from May 16, 2022
Merged

Update spacing below product media #1689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7ab34d9
Update spacing below product media
LucasLacerdaUX May 12, 2022
7aad8ab
Update visible
LucasLacerdaUX May 12, 2022
0801fb1
Remove extra spacing
LucasLacerdaUX May 12, 2022
a333e35
Update desktop layout
LucasLacerdaUX May 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions assets/base.css
View file
Open in desktop
Expand Up @@ -186,6 +186,7 @@
--shadow-vertical-offset: var(--media-shadow-vertical-offset);
--shadow-blur-radius: var(--media-shadow-blur-radius);
--shadow-opacity: var(--media-shadow-opacity);
--shadow-visible: var(--media-shadow-visible);
}

/* base */
Expand Down
4 changes: 2 additions & 2 deletions assets/component-slider.css
View file
Open in desktop
Expand Up @@ -28,8 +28,8 @@ slider-component.slider-component-full-width {

.slider__slide {
--focus-outline-padding: 0.5rem;
--shadow-padding-top: calc(var(--shadow-vertical-offset) * -1 + var(--shadow-blur-radius));
--shadow-padding-bottom: calc(var(--shadow-vertical-offset) + var(--shadow-blur-radius));
--shadow-padding-top: calc((var(--shadow-vertical-offset) * -1 + var(--shadow-blur-radius)) * var(--shadow-visible));
--shadow-padding-bottom: calc((var(--shadow-vertical-offset) + var(--shadow-blur-radius)) * var(--shadow-visible));
scroll-snap-align: start;
flex-shrink: 0;
padding-bottom: 0;
Expand Down
5 changes: 2 additions & 3 deletions assets/section-main-product.css
View file
Open in desktop
Expand Up @@ -472,7 +472,6 @@ a.product__text {
@media screen and (max-width: 749px) {
.product__media-list {
margin-left: -2.5rem;
padding-bottom: 2rem;
margin-bottom: 3rem;
width: calc(100% + 4rem);
}
Expand Down Expand Up @@ -503,11 +502,11 @@ a.product__text {
@media screen and (min-width: 750px) {
.product--thumbnail .product__media-list,
.product--thumbnail_slider .product__media-list {
padding-bottom: var(--media-shadow-vertical-offset);
padding-bottom: calc(var(--media-shadow-vertical-offset) * var(--media-shadow-visible));
LucasLacerdaUX marked this conversation as resolved.
Show resolved Hide resolved
}

.product__media-list {
padding-right: var(--media-shadow-horizontal-offset);
padding-right: calc(var(--media-shadow-horizontal-offset) * var(--media-shadow-visible));
}

.product--thumbnail .product__media-item:not(.is-active),
Expand Down
1 change: 1 addition & 0 deletions layout/theme.liquid
View file
Open in desktop
Expand Up @@ -81,6 +81,7 @@
--media-shadow-horizontal-offset: {{ settings.media_shadow_horizontal_offset }}px;
--media-shadow-vertical-offset: {{ settings.media_shadow_vertical_offset }}px;
--media-shadow-blur-radius: {{ settings.media_shadow_blur }}px;
--media-shadow-visible: {% if settings.media_shadow_opacity > 0 %}1{% else %}0{% endif %};

--page-width: {{ settings.page_width | divided_by: 10 }}rem;
--page-width-margin: {% if settings.page_width == '1600' %}2{% else %}0{% endif %}rem;
Expand Down