Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Badge product card position copy update #1795

Merged
merged 6 commits into from Jun 21, 2022
Merged

Badge product card position copy update #1795

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5494b18
Badge product card position copy update
Oliviammarcello Jun 14, 2022
8db6249
Update 7 translation files
translation-platform[bot] Jun 16, 2022
2c8e7fa
Update 3 translation files
translation-platform[bot] Jun 16, 2022
a7c1b01
Update 6 translation files
translation-platform[bot] Jun 17, 2022
6224d08
Update 3 translation files
translation-platform[bot] Jun 20, 2022
a86caf5
Update 1 translation file
translation-platform[bot] Jun 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion locales/en.default.schema.json
View file
Open in desktop
Expand Up @@ -76,7 +76,7 @@
"options__4": {
"label": "Top right"
},
"label": "Product card position"
"label": "Position on cards"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is nothing in this part of the settings that mentions the blog or page badge. I wonder if it should come up up (info text) or even have a setting (in a future PR if needed) to have a similar option that we have for sale and sold out ones, to pick a color.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good callout Ludo! Looks like the position setting affects the blog and page badges, but neither of the color scheme settings do. @Oliviammarcello maybe something to add to the polish/enhancements list?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah great point. I can add it to the design polish list, thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ill approve the PR once we get all the translations back 🙂

},
"sale_badge_color_scheme": {
"label": "Sale badge color scheme"
Expand Down