Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Badge product card position copy update #1795

Merged
merged 6 commits into from Jun 21, 2022
Merged

Badge product card position copy update #1795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5494b18
Badge product card position copy update
Oliviammarcello Jun 14, 2022
8db6249
Update 7 translation files
translation-platform[bot] Jun 16, 2022
2c8e7fa
Update 3 translation files
translation-platform[bot] Jun 16, 2022
a7c1b01
Update 6 translation files
translation-platform[bot] Jun 17, 2022
6224d08
Update 3 translation files
translation-platform[bot] Jun 20, 2022
a86caf5
Update 1 translation file
translation-platform[bot] Jun 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion locales/cs.schema.json
View file
Open in desktop
Expand Up @@ -268,7 +268,7 @@
"options__4": {
"label": "Nahoře vpravo"
},
"label": "Pozice karty produktu"
"label": "Pozice na kartách"
},
"sale_badge_color_scheme": {
"label": "Barevné schéma odznaku Sleva"
Expand Down
2 changes: 1 addition & 1 deletion locales/da.schema.json
View file
Open in desktop
Expand Up @@ -268,7 +268,7 @@
"options__4": {
"label": "Øverst til højre"
},
"label": "Position for produktkort"
"label": "Placering på kort"
},
"sale_badge_color_scheme": {
"label": "Farveskema for udsalg-badges"
Expand Down
2 changes: 1 addition & 1 deletion locales/de.schema.json
View file
Open in desktop
Expand Up @@ -268,7 +268,7 @@
"options__4": {
"label": "Oben rechts"
},
"label": "Position der Produktkarte"
"label": "Position auf Karten"
},
"sale_badge_color_scheme": {
"label": "Farbschema für Sale-Badges"
Expand Down
2 changes: 1 addition & 1 deletion locales/en.default.schema.json
View file
Open in desktop
Expand Up @@ -76,7 +76,7 @@
"options__4": {
"label": "Top right"
},
"label": "Product card position"
"label": "Position on cards"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is nothing in this part of the settings that mentions the blog or page badge. I wonder if it should come up up (info text) or even have a setting (in a future PR if needed) to have a similar option that we have for sale and sold out ones, to pick a color.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good callout Ludo! Looks like the position setting affects the blog and page badges, but neither of the color scheme settings do. @Oliviammarcello maybe something to add to the polish/enhancements list?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah great point. I can add it to the design polish list, thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ill approve the PR once we get all the translations back 🙂

},
"sale_badge_color_scheme": {
"label": "Sale badge color scheme"
Expand Down
2 changes: 1 addition & 1 deletion locales/es.schema.json
View file
Open in desktop
Expand Up @@ -268,7 +268,7 @@
"options__4": {
"label": "Arriba a la derecha"
},
"label": "Posición de tarjeta de producto"
"label": "Posición de las tarjetas"
},
"sale_badge_color_scheme": {
"label": "Esquema de color de distintivo de oferta"
Expand Down
2 changes: 1 addition & 1 deletion locales/fi.schema.json
View file
Open in desktop
Expand Up @@ -268,7 +268,7 @@
"options__4": {
"label": "Ylhäällä oikealla"
},
"label": "Tuotekortin sijainti"
"label": "Sijainti korteilla"
},
"sale_badge_color_scheme": {
"label": "Alennusmyynti-tunnuksen värimalli"
Expand Down
2 changes: 1 addition & 1 deletion locales/fr.schema.json
View file
Open in desktop
Expand Up @@ -268,7 +268,7 @@
"options__4": {
"label": "En haut à droite"
},
"label": "Position de la carte de produit"
"label": "Position sur les cartes"
},
"sale_badge_color_scheme": {
"label": "Combinaison de couleurs du badge de vente"
Expand Down
2 changes: 1 addition & 1 deletion locales/it.schema.json
View file
Open in desktop
Expand Up @@ -268,7 +268,7 @@
"options__4": {
"label": "In alto a destra"
},
"label": "Posizione scheda prodotto"
"label": "Posizione sulle schede"
},
"sale_badge_color_scheme": {
"label": "Schema colori per badge vendita"
Expand Down
2 changes: 1 addition & 1 deletion locales/ja.schema.json
View file
Open in desktop
Expand Up @@ -268,7 +268,7 @@
"options__4": {
"label": "右上"
},
"label": "商品カードの位置"
"label": "カードでの位置"
},
"sale_badge_color_scheme": {
"label": "販売バッジの配色"
Expand Down
2 changes: 1 addition & 1 deletion locales/ko.schema.json
View file
Open in desktop
Expand Up @@ -268,7 +268,7 @@
"options__4": {
"label": "오른쪽 상단"
},
"label": "제품 카드 위치"
"label": "카드에서의 위치"
},
"sale_badge_color_scheme": {
"label": "할인 배지 색상 체계"
Expand Down
2 changes: 1 addition & 1 deletion locales/nb.schema.json
View file
Open in desktop
Expand Up @@ -268,7 +268,7 @@
"options__4": {
"label": "Øverst til høyre"
},
"label": "Posisjon for produktkort"
"label": "Plassering på kort"
},
"sale_badge_color_scheme": {
"label": "Fargetema for salgsmerke"
Expand Down
2 changes: 1 addition & 1 deletion locales/nl.schema.json
View file
Open in desktop
Expand Up @@ -268,7 +268,7 @@
"options__4": {
"label": "Rechtsboven"
},
"label": "Positie productkaart"
"label": "Positie op kaarten"
},
"sale_badge_color_scheme": {
"label": "Kleurschema uitverkoop-badge"
Expand Down
2 changes: 1 addition & 1 deletion locales/pl.schema.json
View file
Open in desktop
Expand Up @@ -268,7 +268,7 @@
"options__4": {
"label": "Do góry, do prawej"
},
"label": "Położenie karty produktu"
"label": "Położenie na kartach"
},
"sale_badge_color_scheme": {
"label": "Kolorystyka znaczków Wyprzedaż"
Expand Down
2 changes: 1 addition & 1 deletion locales/pt-BR.schema.json
View file
Open in desktop
Expand Up @@ -268,7 +268,7 @@
"options__4": {
"label": "Canto superior direito"
},
"label": "Posição do cartão do produto"
"label": "Posição em cartões"
},
"sale_badge_color_scheme": {
"label": "Esquema de cores do selo de promoção"
Expand Down
2 changes: 1 addition & 1 deletion locales/pt-PT.schema.json
View file
Open in desktop
Expand Up @@ -268,7 +268,7 @@
"options__4": {
"label": "Canto superior direito"
},
"label": "Posição do cartão de produto"
"label": "Posição nos cartões"
},
"sale_badge_color_scheme": {
"label": "Esquema de cor do selo de venda"
Expand Down
2 changes: 1 addition & 1 deletion locales/sv.schema.json
View file
Open in desktop
Expand Up @@ -268,7 +268,7 @@
"options__4": {
"label": "Överst till höger"
},
"label": "Position för produktkort"
"label": "Position på kort"
},
"sale_badge_color_scheme": {
"label": "Färgschema för försäljningsbricka"
Expand Down
2 changes: 1 addition & 1 deletion locales/th.schema.json
View file
Open in desktop
Expand Up @@ -268,7 +268,7 @@
"options__4": {
"label": "ขวาบน"
},
"label": "ตำแหน่งบัตรสินค้า"
"label": "ตำแหน่งบนบัตร"
},
"sale_badge_color_scheme": {
"label": "รูปแบบสีของเครื่องหมายลดราคา"
Expand Down
2 changes: 1 addition & 1 deletion locales/tr.schema.json
View file
Open in desktop
Expand Up @@ -268,7 +268,7 @@
"options__4": {
"label": "Üst sağ"
},
"label": "Ürün kartı konumu"
"label": "Kartlardaki konum"
},
"sale_badge_color_scheme": {
"label": "İndirim rozeti renk şeması"
Expand Down
2 changes: 1 addition & 1 deletion locales/vi.schema.json
View file
Open in desktop
Expand Up @@ -268,7 +268,7 @@
"options__4": {
"label": "Trên cùng bên phải"
},
"label": "Vị trí thẻ sản phẩm"
"label": "Vị trí trên thẻ"
},
"sale_badge_color_scheme": {
"label": "Bảng màu huy hiệu giảm giá"
Expand Down
2 changes: 1 addition & 1 deletion locales/zh-CN.schema.json
View file
Open in desktop
Expand Up @@ -268,7 +268,7 @@
"options__4": {
"label": "右上方"
},
"label": "产品卡位置"
"label": "在卡上的位置"
},
"sale_badge_color_scheme": {
"label": "促销徽章配色方案"
Expand Down
2 changes: 1 addition & 1 deletion locales/zh-TW.schema.json
View file
Open in desktop
Expand Up @@ -268,7 +268,7 @@
"options__4": {
"label": "上方靠右"
},
"label": "產品卡片位置"
"label": "卡片上的位置"
},
"sale_badge_color_scheme": {
"label": "銷售徽章顏色配置"
Expand Down