Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inventory status block #1979
Inventory status block #1979
Changes from 11 commits
28ce656
31a7a62
4abe91b
c16dfd2
205cfa3
c0352d2
ae96b0e
a31ca80
c21413f
7e141aa
61cab11
72396e7
5493fac
ac88a5f
ce1d908
e374ff7
2155480
195efcb
0e4d858
a65035c
d0fba5a
60f9a3e
2b5aebc
0593c44
7e128b7
fcfd6f9
a7af905
16b4e29
0349d17
23428cc
d1613e8
5298f02
59a5eb9
2f6bfb7
0579422
12b2a1e
21b9028
ae09d94
8b721ff
1378c49
81f2f77
1180fbe
7594b1c
9cec4de
a699366
d8e5165
8e3b06f
c371fe2
f730ed9
9f78bc7
de06ded
663c0eb
0950d46
9a6d32c
a57786f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this
info
bit is actually useful 🤔 Maybe it's just me though 😅Choose 0 to always show the status as 'in stock' if the variant is available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it seem too obvious for you? Is that what you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just find it a bit confusing. I think the wording could be better. But maybe it's only confusing to me. cc: @YoannJailin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ludoboludo how about this one?
« Shows low stock status when quantity is below the threshold. Choose 0 to always show in stock if the product is available. »
I wonder if it's not confusing to refer to the variant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I even wonder if it needs help text ? Or maybe something to explain how this value they're using is used.
Anything below the threshold set will show a
low stockstatus unless it's 0.