Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull update from release branch and update version number and release notes #3229

Merged
merged 7 commits into from
Jan 31, 2024

Conversation

ludoboludo
Copy link
Contributor

Pulling in all the stuff we had on the release branch that isn't on main.
Also updating the version number and release notes.

ludoboludo and others added 7 commits January 17, 2024 10:59
* change color reference

* remove character

* increase to meet contrast ratio of 3
* Update info text

* remove duplication

* add space

* clean up language and association

* add to second place

* Update 9 translation files

* Update 4 translation files

* Update 6 translation files

* Update 1 translation file

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
… '1 item' on 'Remove all' confirmation (#3203)

* Change the message when removing only one item from the QOL

* Update 20 translation files

* Update 6 translation files

* Update 4 translation files

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Copy link
Contributor

@andrewetchen andrewetchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ludoboludo ludoboludo merged commit c77ebf5 into main Jan 31, 2024
7 of 8 checks passed
@ludoboludo ludoboludo deleted the pull-update-from-release branch January 31, 2024 18:15
ludoboludo added a commit that referenced this pull request Feb 8, 2024
* Update 1 translation file (#3202)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Pull update from release branch and update version number and release notes (#3229)

* Fix translation path (#3198)

* Change product variant swatches' border color (#3204)

* change color reference

* remove character

* increase to meet contrast ratio of 3

* Update swatch setting info text (#3205)

* Update info text

* remove duplication

* add space

* clean up language and association

* add to second place

* Update 9 translation files

* Update 4 translation files

* Update 6 translation files

* Update 1 translation file

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* [Quick order list] Change 'plural' string to 'singular' when removing '1 item' on 'Remove all' confirmation (#3203)

* Change the message when removing only one item from the QOL

* Update 20 translation files

* Update 6 translation files

* Update 4 translation files

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update 1 translation file (#3202)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* update version number and release notes

---------

Co-authored-by: melissaperreault <melissa.perreault@shopify.com>
Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: Eugene Kasimov <105315663+eugenekasimov@users.noreply.github.com>

* Update 1 translation file (#3232)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Fix cart drawer header background and cart note summary spacing

* more cart drawer touch ups

* remove some of the unwanted changes

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: melissaperreault <melissa.perreault@shopify.com>
Co-authored-by: Eugene Kasimov <105315663+eugenekasimov@users.noreply.github.com>
SmolSoftBoi pushed a commit to m-k-enterprises/dawn that referenced this pull request Feb 18, 2024
… notes (Shopify#3229)

* Fix translation path (Shopify#3198)

* Change product variant swatches' border color (Shopify#3204)

* change color reference

* remove character

* increase to meet contrast ratio of 3

* Update swatch setting info text (Shopify#3205)

* Update info text

* remove duplication

* add space

* clean up language and association

* add to second place

* Update 9 translation files

* Update 4 translation files

* Update 6 translation files

* Update 1 translation file

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* [Quick order list] Change 'plural' string to 'singular' when removing '1 item' on 'Remove all' confirmation (Shopify#3203)

* Change the message when removing only one item from the QOL

* Update 20 translation files

* Update 6 translation files

* Update 4 translation files

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update 1 translation file (Shopify#3202)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* update version number and release notes

---------

Co-authored-by: melissaperreault <melissa.perreault@shopify.com>
Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: Eugene Kasimov <105315663+eugenekasimov@users.noreply.github.com>
ludoboludo added a commit that referenced this pull request Feb 23, 2024
* Fix translation path (#3198)

* Change product variant swatches' border color (#3204)

* change color reference

* remove character

* increase to meet contrast ratio of 3

* Update swatch setting info text (#3205)

* Update info text

* remove duplication

* add space

* clean up language and association

* add to second place

* Update 9 translation files

* Update 4 translation files

* Update 6 translation files

* Update 1 translation file

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* [Quick order list] Change 'plural' string to 'singular' when removing '1 item' on 'Remove all' confirmation (#3203)

* Change the message when removing only one item from the QOL

* Update 20 translation files

* Update 6 translation files

* Update 4 translation files

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Fix drawer stylings (#3248)

* Update 1 translation file (#3202)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Pull update from release branch and update version number and release notes (#3229)

* Fix translation path (#3198)

* Change product variant swatches' border color (#3204)

* change color reference

* remove character

* increase to meet contrast ratio of 3

* Update swatch setting info text (#3205)

* Update info text

* remove duplication

* add space

* clean up language and association

* add to second place

* Update 9 translation files

* Update 4 translation files

* Update 6 translation files

* Update 1 translation file

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* [Quick order list] Change 'plural' string to 'singular' when removing '1 item' on 'Remove all' confirmation (#3203)

* Change the message when removing only one item from the QOL

* Update 20 translation files

* Update 6 translation files

* Update 4 translation files

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update 1 translation file (#3202)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* update version number and release notes

---------

Co-authored-by: melissaperreault <melissa.perreault@shopify.com>
Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: Eugene Kasimov <105315663+eugenekasimov@users.noreply.github.com>

* Update 1 translation file (#3232)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Fix cart drawer header background and cart note summary spacing

* more cart drawer touch ups

* remove some of the unwanted changes

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: melissaperreault <melissa.perreault@shopify.com>
Co-authored-by: Eugene Kasimov <105315663+eugenekasimov@users.noreply.github.com>

* fix missing alt tags for collection images (#3262)

* Update titles (#3265)

* Condense country selector width when there are no currencies (#3269)

* Recreate existing PR based on the right branch (#3274)

* Fix product review alignment when product doesn't have medias (#3264)

* Fix product review alignment when product doesn't have medias

* Add the escape to match with branch target

* Touch up scroll into view PDP (#3276)

* Fix mobile behaviour for scroll into view

* remove conditions

* remove unused data attribute (#3277)

* Remove sticky header on cart drawer to avoid overlap of content (#3279)

* fix scrolling scenario on mobile (#3286)

* Update 1 translation file (#3202)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Pull update from release branch and update version number and release notes (#3229)

* Fix translation path (#3198)

* Change product variant swatches' border color (#3204)

* change color reference

* remove character

* increase to meet contrast ratio of 3

* Update swatch setting info text (#3205)

* Update info text

* remove duplication

* add space

* clean up language and association

* add to second place

* Update 9 translation files

* Update 4 translation files

* Update 6 translation files

* Update 1 translation file

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* [Quick order list] Change 'plural' string to 'singular' when removing '1 item' on 'Remove all' confirmation (#3203)

* Change the message when removing only one item from the QOL

* Update 20 translation files

* Update 6 translation files

* Update 4 translation files

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update 1 translation file (#3202)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* update version number and release notes

---------

Co-authored-by: melissaperreault <melissa.perreault@shopify.com>
Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: Eugene Kasimov <105315663+eugenekasimov@users.noreply.github.com>

* Update 1 translation file (#3232)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update README.md (#3128)

* Update README.md

* fix url formatting

---------

Co-authored-by: Ludo <ludo.segura@shopify.com>

* Fix Theme Check offences (#3283)

* Fix schema JSON formatting

Co-authored-by: Abhishek Jani <abhishekdarshanjani@gmail.com>

* Add loading=eager attribute to gift card page img

* Use liquid tag to combine successive liquid statements

Co-authored-by: Abhishek Jani <abhishekdarshanjani@gmail.com>

* Remove snippet to avoid > 3 levels of nested snippets

* Ignore AssetPreload theme check for font links

---------

Co-authored-by: Abhishek Jani <abhishekdarshanjani@gmail.com>

* update release notes

---------

Co-authored-by: melissaperreault <melissa.perreault@shopify.com>
Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: Eugene Kasimov <105315663+eugenekasimov@users.noreply.github.com>
Co-authored-by: Renan Souza <77407058+renanvsouza@users.noreply.github.com>
Co-authored-by: Abdulrahman Hamideh <abdulrahman.hamideh@shopify.com>
Co-authored-by: Benjamin Sehl <ben@sehl.ca>
Co-authored-by: Kai <KaichenWang@users.noreply.github.com>
Co-authored-by: Abhishek Jani <abhishekdarshanjani@gmail.com>
ethanclevenger91 pushed a commit to ethanclevenger91/dawn that referenced this pull request Feb 27, 2024
* Update 1 translation file (Shopify#3202)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Pull update from release branch and update version number and release notes (Shopify#3229)

* Fix translation path (Shopify#3198)

* Change product variant swatches' border color (Shopify#3204)

* change color reference

* remove character

* increase to meet contrast ratio of 3

* Update swatch setting info text (Shopify#3205)

* Update info text

* remove duplication

* add space

* clean up language and association

* add to second place

* Update 9 translation files

* Update 4 translation files

* Update 6 translation files

* Update 1 translation file

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* [Quick order list] Change 'plural' string to 'singular' when removing '1 item' on 'Remove all' confirmation (Shopify#3203)

* Change the message when removing only one item from the QOL

* Update 20 translation files

* Update 6 translation files

* Update 4 translation files

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update 1 translation file (Shopify#3202)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* update version number and release notes

---------

Co-authored-by: melissaperreault <melissa.perreault@shopify.com>
Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: Eugene Kasimov <105315663+eugenekasimov@users.noreply.github.com>

* Update 1 translation file (Shopify#3232)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Fix cart drawer header background and cart note summary spacing

* more cart drawer touch ups

* remove some of the unwanted changes

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: melissaperreault <melissa.perreault@shopify.com>
Co-authored-by: Eugene Kasimov <105315663+eugenekasimov@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants