Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change size of swatch on mobile #3348

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Change size of swatch on mobile #3348

merged 1 commit into from
Mar 15, 2024

Conversation

jas7457
Copy link
Contributor

@jas7457 jas7457 commented Mar 15, 2024

PR Summary:

Changes the swatch size from 44px to 36px on the product details page, for mobile only.

Why are these changes introduced?

Fixes https://github.com/Shopify/custom-data-issues/issues/2334

What approach did you take?

Simply update the css variable.

Visual impact on existing themes

The swatches on PDP will be slightly smaller

Testing steps/scenarios

  • View my Taxonomy Product and ensure that the swatch is 36px on mobile
  • Ensure this style does not bleed to swatch filters
  • Ensure this style does not bleed to the variant dropdown

Demo links

Checklist

@mkoenig-shopify mkoenig-shopify marked this pull request as ready for review March 15, 2024 15:16
Copy link
Member

@alisterdev alisterdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tweaking this! 🙌
🎩

@jas7457
Copy link
Contributor Author

jas7457 commented Mar 15, 2024

Looks like I need 2 approvals - @mkoenig-shopify can you give it an approval too?

Copy link

@mkoenig-shopify mkoenig-shopify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@jas7457 jas7457 merged commit f907e3d into main Mar 15, 2024
8 checks passed
@jas7457 jas7457 deleted the jas7457/mobile-swatch-size branch March 15, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants