Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed max products per page to 36 #3384

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

tyleralsbury
Copy link
Contributor

@tyleralsbury tyleralsbury commented Apr 2, 2024

PR Summary:

A quick PR to bump max products per page to 36.

Why are these changes introduced?

6 column grid necessitates more products per page.

What approach did you take?

Changed an integer. 馃く

Other considerations

Performance impact was assessed - document size is not significantly different. TTFB did not change significantly either.

Visual impact on existing themes

None, unless they change the setting.

Testing steps/scenarios

  • Add enough products to hit 36 on the all products page
  • Change the setting in the main product grid
  • Look upon the glory of a large product grid
  • Cheer with excitement

Demo links

Store
Editor

Checklist

Copy link
Contributor

@melissaperreault melissaperreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃敟

@tyleralsbury tyleralsbury merged commit bb1e198 into main Apr 3, 2024
4 of 5 checks passed
@tyleralsbury tyleralsbury deleted the bump-max-grid-items branch April 3, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants