Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Shop Login Button liquid drop provider on login template #3390

Merged
merged 5 commits into from
Apr 4, 2024

Conversation

QuintonC
Copy link
Contributor

@QuintonC QuintonC commented Apr 2, 2024

PR Summary:

Adds a sign in with Shop button to the Classic Customer Accounts login form. This includes the ability for the button to be hidden by merchants who do not wish to show the shop login button.

What approach did you take?

Extended on the existing implementation in main-login.liquid by utilizing our Shop login button liquid drop with additional settings which allow the button to be hidden.

I've also added translation strings for the settings and the separator (or) text.

Additionally, the login button inherits the border radii set by merchants via the CSS variable.

Visual impact on existing themes

Merchants who are using Dawn or other OS2.0 themes will see an added Sign in with Shop button on their classic customer accounts page.

It can be hidden by merchants if desired by toggling the "Hide button" setting.

Hide Button setting

image

Testing steps/scenarios

  • Navigate to the test store (link)
  • Go to /accounts/login
  • Click the button, and sign in using a Shop account. If you do not have one, you can create one through the sign in with Shop flow.
  • After signing in, refresh the page
    • This is only a temporary step until we patch the classic customer accounts script to update the button added by this change rather than appending a hidden button the bottom of the page.
  • You should be authenticated to your customer account

Demo links

Checklist

@QuintonC QuintonC force-pushed the qc/login-add-shop-login-button-settings branch from d8d4727 to c210b52 Compare April 2, 2024 21:42
@QuintonC QuintonC requested a review from a team April 2, 2024 21:42
Copy link
Contributor

@melissaperreault melissaperreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey team! Made a few comments that I'll regroup below:

  • Order of setting can be revised: moving up the checkbox setting will bring coherence in how other sections places the padding settings always at the very end of the sidebar.
  • We don't need a header if the setting is already explicit. Also reduces noise for merchants.
  • Have the setting label use a positive form

sections/main-login.liquid Outdated Show resolved Hide resolved
sections/main-login.liquid Outdated Show resolved Hide resolved
locales/en.default.schema.json Outdated Show resolved Hide resolved
@QuintonC QuintonC force-pushed the qc/login-add-shop-login-button-settings branch from c210b52 to 562b1c7 Compare April 3, 2024 02:26
@QuintonC QuintonC force-pushed the qc/login-add-shop-login-button-settings branch from 562b1c7 to 78cb8af Compare April 3, 2024 02:26
@QuintonC QuintonC merged commit 5ad5d44 into main Apr 4, 2024
2 of 5 checks passed
@QuintonC QuintonC deleted the qc/login-add-shop-login-button-settings branch April 4, 2024 16:13
QuintonC pushed a commit that referenced this pull request Apr 5, 2024
* Update 13 translation files

* Update 2 translation files

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: Sofia Matulis <sofiamatulis@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants