-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Shop Login Button liquid drop provider on login template #3390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mishakorablin
approved these changes
Apr 2, 2024
QuintonC
force-pushed
the
qc/login-add-shop-login-button-settings
branch
from
April 2, 2024 21:42
d8d4727
to
c210b52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey team! Made a few comments that I'll regroup below:
- Order of setting can be revised: moving up the checkbox setting will bring coherence in how other sections places the padding settings always at the very end of the sidebar.
- We don't need a header if the setting is already explicit. Also reduces noise for merchants.
- Have the setting label use a positive form
QuintonC
force-pushed
the
qc/login-add-shop-login-button-settings
branch
from
April 3, 2024 02:26
c210b52
to
562b1c7
Compare
QuintonC
force-pushed
the
qc/login-add-shop-login-button-settings
branch
from
April 3, 2024 02:26
562b1c7
to
78cb8af
Compare
tyleralsbury
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Adds a sign in with Shop button to the Classic Customer Accounts login form. This includes the ability for the button to be hidden by merchants who do not wish to show the shop login button.
What approach did you take?
Extended on the existing implementation in
main-login.liquid
by utilizing our Shop login button liquid drop with additional settings which allow the button to be hidden.I've also added translation strings for the settings and the separator (
or
) text.Additionally, the login button inherits the border radii set by merchants via the CSS variable.
Visual impact on existing themes
Merchants who are using Dawn or other OS2.0 themes will see an added Sign in with Shop button on their classic customer accounts page.
It can be hidden by merchants if desired by toggling the "Hide button" setting.
Hide Button setting
Testing steps/scenarios
/accounts/login
Demo links
Checklist