Add disabled state to Quick Add Bulk #3391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-menard
reviewed
Apr 3, 2024
| @@ -99,7 +99,7 @@ if (!customElements.get('quick-add-bulk')) { | |||
| updateCart(event) { | |||
| this.lastActiveInputId = event.target.getAttribute('data-index'); | |||
| this.quantity = this.querySelector('quantity-input') | |||
| // this.quantity.classList.add('loading'); | |||
There was a problem hiding this comment.
This seems to be an old comment 😅 So I am removing to clean it up as well
tyleralsbury
approved these changes
Apr 3, 2024
dan-menard
approved these changes
Apr 3, 2024
sofiamatulis
force-pushed
the
disabled-state-quickbulk
branch
from
f7aef30
to
9c0f0df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Ensure we are blocking the input from being edited like in QOL (https://screenshot.click/03-33-2875m-wdmj0.mp4) when the API call is being made.
Why are these changes introduced?
Ensure the buyer cant edit the input as an API call is being made
Before:
Screen.Recording.2024-04-02.at.9.20.29.PM.mov
After:
https://screenshot.click/03-40-re1d5-f31xd.mp4
https://screenshot.click/03-18-pgft9-pgzme.mp4
Testing steps/scenarios
Demo links
Checklist