Adds eligibility check to prevent orphaned DOM from rendering #3412
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Adds a condition around the newly introduced standalone sign in button on the account login page.
Why are these changes introduced?
If a merchant has sign in with Shop disabled for customer sign ins, we should not render the login button. This was handled in the backend by an eligibility check, but a theme developer wouldn't have the ability to use this condition.
What approach did you take?
Use the
login_with_shop_classic_customer_accounts?
feature to hide the elements. This condition has been around for 16 months now, but not sure how widespread its usage is.Other considerations
Decision log
Visual impact on existing themes
If a merchant has sign in with Shop setting disabled, we will not render the "or" text, as well as the login button.
Testing steps/scenarios
or
text should not display.Demo links
Checklist