Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds eligibility check to prevent orphaned DOM from rendering #3412

Merged

Conversation

mtbottens
Copy link
Contributor

PR Summary:

Adds a condition around the newly introduced standalone sign in button on the account login page.

Why are these changes introduced?

If a merchant has sign in with Shop disabled for customer sign ins, we should not render the login button. This was handled in the backend by an eligibility check, but a theme developer wouldn't have the ability to use this condition.

What approach did you take?

Use the login_with_shop_classic_customer_accounts? feature to hide the elements. This condition has been around for 16 months now, but not sure how widespread its usage is.

Other considerations

Decision log

# Decision Alternatives Rationale Downsides
1

Visual impact on existing themes

If a merchant has sign in with Shop setting disabled, we will not render the "or" text, as well as the login button.

image

Testing steps/scenarios

  • Visit the sign in page
  • The sign in button AND the or text should not display.

Demo links

Checklist

@mtbottens mtbottens merged commit 0d8c306 into main Apr 11, 2024
6 of 8 checks passed
@mtbottens mtbottens deleted the mb/add-eligibility-condition-around-standalone-button branch April 11, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants