Skip to content
This repository has been archived by the owner on Apr 27, 2021. It is now read-only.

Adds 'redis.expires.percent' to redis checks #1

Closed
wants to merge 2 commits into from

Conversation

pallan
Copy link

@pallan pallan commented Jun 30, 2014

Allows tracking the percentage difference between keys and expired keys so that you can create alerts on that value in Datadog.

This is a direct copy from the work done by @wisq in our internal cookbooks, https://github.com/Shopify/cookbooks/pull/2871

For review, @wisq @skingry

If it looks okay we can open a PR with DD.

@skingry
Copy link

skingry commented Jun 30, 2014

Looks good. When you open a PR with DataDog, make sure to note that the reason for this check is lack of acceptable math functions on existing metrics within their web application. They might end up approving the PR (signaling that they do not intend to add the math functions) or deny the PR (which signals the opposite). Either way, we win.

@wisq
Copy link

wisq commented Jul 3, 2014

LGTM. You gonna handle the datadog PR, or should I?

@pallan
Copy link
Author

pallan commented Jul 3, 2014

Go ahead, it is your work after all :-)

Peer Allan
Operations Engineer - Shopify

On Jul 3, 2014, at 12:41 PM, Adrian Irving-Beer notifications@github.com wrote:

LGTM. You gonna handle the opscode PR, or should I?


Reply to this email directly or view it on GitHub.

Peer Allan added 2 commits July 3, 2014 14:03
Allows tracking the percentage difference between keys and expired keys so that you can create alerts on that value in Datadog.
@wisq
Copy link

wisq commented Jul 3, 2014

Rebased on latest DD master.

@pallan
Copy link
Author

pallan commented Jul 7, 2014

Re: DataDog#1015

@pallan
Copy link
Author

pallan commented Jul 28, 2014

This was merged into datadog master, shall we merge this in or just wait and pull from upstream when released?

@skingry
Copy link

skingry commented Jul 28, 2014

I'd pull from upstream.

@pallan
Copy link
Author

pallan commented Aug 19, 2014

Will pull from upstream.

@pallan pallan closed this Aug 19, 2014
jpittis pushed a commit that referenced this pull request Jun 2, 2015
Get upstream commits from DataDog
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants