Skip to content

Commit

Permalink
Revert "Version Packages (#42)"
Browse files Browse the repository at this point in the history
This reverts commit 76a641b.
  • Loading branch information
devisscher committed Sep 2, 2022
1 parent 76a641b commit c28dc87
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 16 deletions.
5 changes: 5 additions & 0 deletions .changeset/funny-actors-suffer.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/discount-app-components': patch
---

update changelog file name
5 changes: 5 additions & 0 deletions .changeset/wild-donuts-unite.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/discount-app-components': patch
---

update release config to publish to npm
6 changes: 3 additions & 3 deletions .github/workflows/node-ci.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
name: Node-CI

on:
pull_request:
branches:
- main
pull_request: ~
push:
branches: [main]

jobs:
node-tests:
Expand Down
8 changes: 0 additions & 8 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,5 @@
# @shopify/discount-app-components

## 1.0.5

### Patch Changes

- [#41](https://github.com/Shopify/discount-app-components/pull/41) [`31abc78`](https://github.com/Shopify/discount-app-components/commit/31abc7846c6c3e829e9ed855436a31c27ec7a6ad) Thanks [@devisscher](https://github.com/devisscher)! - update changelog file name

- [#41](https://github.com/Shopify/discount-app-components/pull/41) [`31abc78`](https://github.com/Shopify/discount-app-components/commit/31abc7846c6c3e829e9ed855436a31c27ec7a6ad) Thanks [@devisscher](https://github.com/devisscher)! - update release config to publish to npm

## 1.0.4

### Patch Changes
Expand Down
7 changes: 3 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,6 @@ You may need to update your webpack.config.js to include a `module.rules` of:
### New version and releasing
1. When feature work is merged into main there is a release GitHub action which will run.
2. If you want to include those changes into the changelog, run `yarn changeset add` and commit the generated changesets. If you don't want to include those changes in the changelog, you can label your pr with 🤖 Skip Changelog.
3. It runs `yarn version` and incorporates the changesets into the changelog.
4. It bumps the version accordingly. If changesets contain minor changes then the minor version is bumped.
5. The release action runs `yarn release`, which publishes the package to npm.
2. It runs `yarn version` and incorporates the changesets into the changelog.
3. It bumps the version accordingly. If changesets contain minor changes then the minor version is bumped.
4. The release action runs `yarn release`, which runs the `tag` command because we are using a different tool (Shipit), to publish our package. It creates a vX.X.X tag, which can then be picked up by Shipit.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@shopify/discount-app-components",
"description": "Shopify’s discounts component library",
"version": "1.0.5",
"version": "1.0.4",
"author": "Shopify <dev@shopify.com>",
"repository": "https://github.com/Shopify/discount-app-components",
"bugs": "https://github.com/Shopify/discount-app-components/issues",
Expand Down

0 comments on commit c28dc87

Please sign in to comment.