Update HelpText to maintain parity with what is currently in web

[knames]

Updated HelpText combo card to match what is currently on Web.

Figma: https://www.figma.com/file/m81kpkSdIYieWQQA9rl5qr/Extensible-Discounts-Main-File?node-id=8053%3A142722#215788222

Work done in Web: https://github.com/Shopify/web/pull/67404/files#diff-d19bbdbc75c3532233b29c7d18d337618cf24497545a03b7bef3693fce4429f9

What problem is this PR Solving?

Addressing the feedback from Glen and UX team for combinations card

https://github.com/Shopify/web/commit/c7ccafb42c1c789cfa300c6bb1c8a9d4b1ef8984 Empty state changes
Update copy
Remove icon and update the layout
https://github.com/Shopify/web/commit/033384ae6347941902722119536082db0d1b5087 Combinations changes
Update CTA content to have a special case for product combines with product scenario
Update main copy to only have warning about overdiscounting when product combines with product

Resolves https://github.com/Shopify/core-issues/issues/40640

Reviewer Hatrack:

• pull this branch down locally
• yarn install
• yarn storybook
• http://localhost:62672/?path=/story/combinationcard-pattern--combination-card-pattern (or whatever port you get)
• in CombinationCardPattern.tsx you can modify:

orderDiscounts: false,
    productDiscounts: false,
    shippingDiscounts: true,

and

 combinableDiscountCounts={{
          orderDiscountsCount: 0,
          productDiscountsCount: 3,
          shippingDiscountsCount: 0,
        }}

and

        discountClass={DiscountClass.Product}

to run through the different states/copy

Product with Product and Shipping combos

Product with No combos

What is the impact of this PR?

Make sure you consider Shopify experience values and any consequences on Merchants or on Shopify.

On Merchants

On Shopify

Before you deploy

• This PR is safe to rollback. ⚠️ This field is required.¹
• I tophatted this change.²
  • I tophatted this change with a fresh login.³
• I tophatted this change in staging if it is a risky change that requires additional testing in a safe environment before shipping to canaries.²
• I tophatted this change with production assets if it meaningfully changes files in the /foundation or /server directories, or if it updates a key dependency like Polaris or sewing kit.

Footnotes

1. If it is not safe, please detail what would need to happen to make it safe. For example, if this PR removes a GraphQL field that will then be removed from the schema, link to the Shopify Core PR that removes the field. ↩

2. If you are having difficulties accessing or deploying to staging, or you are having difficulties running the production build, please ask in #shopify-web. ↩ ↩²

3. Instead of just refreshing when switching between production/staging/canaries, consider performing a fresh login, especially when your changes touch configuration or the server middleware. ↩

[devisscher]

I don't think so, but I wouldn't be the one to make the call. I think web-utilities has a lot of private code.

[carrotderek]

Agreed! This comment can be removed.

[knames]

oh hey derek commented on this i forgot to remove the comment. thanks!

[knames]

oh and there's derek again, thanks!

[devisscher]

👍

[carrotderek]

🎩 and code lgtm! Just waiting for translations to come back.

[lone-star]

nit: I don't think you need to use a fragment here

[lone-star]

Didn't 🎩 , but code is 👍