Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use gaap token for gh actions #49

Merged
merged 2 commits into from
Sep 9, 2022
Merged

ci: use gaap token for gh actions #49

merged 2 commits into from
Sep 9, 2022

Conversation

devisscher
Copy link
Contributor

@devisscher devisscher commented Sep 9, 2022

Do not merge this PR until the linked PR is merged

** AND ** Wait for the workflow to rotate the secrets to have run once.

We've onboarded the repo on GAAP - which will provide repo specific access tokens to our gh actions. This should allow CI actions to run on GH. GitHub actions are not meant to run in succession when triggered by eachother. (Limits possibility of getting into a action loop or abuse).

@devisscher devisscher requested a review from a team September 9, 2022 18:03
@devisscher devisscher self-assigned this Sep 9, 2022
@devisscher devisscher merged commit 668bf13 into main Sep 9, 2022
@devisscher devisscher deleted the change-gh-token branch September 9, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants