Merge pull request #449 from zjffun/fix/add-over-container-property

fix: add overContainer property to DragOutEvent
Shopify · Oct 11, 2020 · 5acbf88 · 5acbf88
2 parents 74b4855 + 97b817c
commit 5acbf88
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/src/Draggable/Draggable.js b/src/Draggable/Draggable.js
@@ -493,6 +493,7 @@ export default class Draggable {
         sourceContainer: container,
         sensorEvent,
         over: this.currentOver,
+        overContainer: this.currentOverContainer,
       });
 
       this.currentOver.classList.remove(...this.getClassNamesFor('draggable:over'));

diff --git a/src/Draggable/tests/Draggable.test.js b/src/Draggable/tests/Draggable.test.js
@@ -971,4 +971,29 @@ describe('Draggable', () => {
       releaseMouse(newInstance.source);
     });
   });
+
+  describe('when `drag:out`', () => {
+    it('should trigger dragOutEvent', () => {
+      const newInstance = new Draggable(containers, {
+        draggable: 'li',
+      });
+      const draggableElement = sandbox.querySelector('li');
+      document.elementFromPoint = () => draggableElement;
+
+      newInstance.on('drag:out', (event) => {
+        expect(event.overContainer).toBe(containers[0]);
+      });
+
+      clickMouse(draggableElement);
+
+      waitForDragDelay();
+
+      document.elementFromPoint = () => draggableElement.nextElementSibling;
+      moveMouse(draggableElement.nextElementSibling);
+
+      waitForDragDelay();
+
+      releaseMouse(newInstance.source);
+    });
+  });
 });