Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make drag:stop cancellable #525

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Make drag:stop cancellable #525

merged 2 commits into from
Jun 28, 2022

Conversation

hnrq
Copy link
Contributor

@hnrq hnrq commented Jun 26, 2022

Thank you for submitting a pull request! Please make sure you have read the contribution guidelines before proceeding.

This PR implements...

Makes drag:stop cancellable. Once cancelled, originalSource returns to its initial position. The item won't be moved. Also, replace HTMLNode.parentNode.removeChild(HTMLNode) with HTMLNode.remove().

This PR closes the following issues...

Addresses #524

Does this PR require the Docs to be updated?

Yes

Does this PR require new tests?

No

This branch been tested on... (click all that apply / add new items)

Browsers:

  • Chrome 102.0.5005.115
  • Firefox 102.0.5005.115
  • Safari 15.4 (17613.1.17.1.13)
  • IE / Edge version
  • iOS Browser version
  • Android Browser 11 (org.lineageos.jelly)

@zjffun zjffun self-requested a review June 28, 2022 09:36
@tsov
Copy link
Member

tsov commented Jun 28, 2022

FYI: HTMLElement.remove() may not work on older browsers, but then again, maybe it's time to move on from IE11 lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants