Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Darwin arm64 (M1) build #82

Merged
merged 1 commit into from
May 17, 2021
Merged

Conversation

juusom
Copy link

@juusom juusom commented Apr 27, 2021

Should fix #79 . This seems to work fine on my M1 MacBook.

Edit: I need to get legal approval for the CLA, will try to get it sorted out ASAP.

@juusom juusom requested a review from burke as a code owner April 27, 2021 06:33
@ghost ghost added the cla-needed label Apr 27, 2021
@juusom
Copy link
Author

juusom commented May 3, 2021

Does someone need to retrigger the CLA check after signing?

@bobthebuilderberlin
Copy link

Eagerly waiting for this to be merged...

@bobthebuilderberlin
Copy link

@burke You seem to be the main contributor. Anything you can do on your side to retrigger the CLA check?

@juusom juusom mentioned this pull request May 14, 2021
@burke
Copy link
Member

burke commented May 17, 2021

Thanks—Sorry for the delay!

@burke burke merged commit 10831b4 into Shopify:master May 17, 2021
@seanstory
Copy link

This seems to work fine on my M1 MacBook.

Forgive me if this is obvious, but how can I build this on my M1 MacBook? I'd love to get this back working without needing to wait for a release. Cloning and running make is failing with an unhelpful error:

$ make
go mod download
go mod tidy
mkdir -p "build/man/man1"
set -euo pipefail ; bundle exec ronn -r --pipe "man/man1/ejson.1.ronn" | gzip > "build/man/man1/ejson.1.gz" || (rm -f "man/man1/ejson.1.ronn" ; false)
make: *** [build/man/man1/ejson.1.gz] Error 1

@juusom
Copy link
Author

juusom commented May 18, 2021

I think I had something similar happen but I don't remember what went wrong. Is your git working tree clean? Also, plain make also tries to build the debs which is probably not what you want on OS X. bundle install followed by make setup gem or make setup binaries should do it?

@escakot
Copy link

escakot commented May 18, 2021

Would there be a new version released soon? So it can be installed via bundler?

@Vugario
Copy link

Vugario commented Jul 2, 2021

Thanks for the fix! We're eagerly waiting for a new release to be pushed so we can start using ejson on our M1 machines again.

@fisherking
Copy link

fisherking commented Jul 8, 2021

@burke sorry for disturbing, but are you going to bump the new version and publish it to rubygems.org at some point of time?

@burke
Copy link
Member

burke commented Jul 14, 2021

Done, sorry for the delay: https://github.com/Shopify/ejson/releases/tag/v1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation fault when running on M1 Macs (Apple Silicon / Darwin arm64)
7 participants