Updated failure tag's text content in junit reporter.

Shopify · Jun 3, 2023 · 9ef15e2 · 9ef15e2
1 parent 89ae2ee
commit 9ef15e2
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -639,7 +639,7 @@ erblint --format junit
   </properties>
   <testcase name="app/views/subscriptions/_loader.html.erb" file="app/views/subscriptions/_loader.html.erb" lineno="1">
     <failure message="SpaceInHtmlTag: Extra space detected where there should be no space." type="SpaceInHtmlTag">
-      <![CDATA[app/views/subscriptions/_loader.html.erb:1:7]]>
+      <![CDATA[SpaceInHtmlTag: Extra space detected where there should be no space. at app/views/subscriptions/_loader.html.erb:1:7]]>
     </failure>
   </testcase>
   <testcase name="app/views/application/index.html.erb" file="app/views/subscriptions/_menu.html.erb"/>

diff --git a/lib/erb_lint/reporters/junit_reporter.rb b/lib/erb_lint/reporters/junit_reporter.rb
@@ -102,7 +102,7 @@ def create_failure(filename, offense)
         failure_element.add_attribute("message", "#{type}: #{message}")
         failure_element.add_attribute("type", type.to_s)
 
-        cdata_element = REXML::CData.new("#{filename}:#{offense.line_number}:#{offense.column}")
+        cdata_element = REXML::CData.new("#{type}: #{message} at #{filename}:#{offense.line_number}:#{offense.column}")
         failure_element.add_text(cdata_element)
 
         failure_element

diff --git a/spec/erb_lint/fixtures/junit.xml b/spec/erb_lint/fixtures/junit.xml
@@ -9,12 +9,12 @@
   </properties>
   <testcase name="app/views/subscriptions/_loader.html.erb" file="app/views/subscriptions/_loader.html.erb" lineno="1">
     <failure message="SpaceInHtmlTag: Extra space detected where there should be no space." type="SpaceInHtmlTag">
-      <![CDATA[app/views/subscriptions/_loader.html.erb:1:7]]>
+      <![CDATA[SpaceInHtmlTag: Extra space detected where there should be no space. at app/views/subscriptions/_loader.html.erb:1:7]]>
     </failure>
   </testcase>
   <testcase name="app/views/subscriptions/_loader.html.erb" file="app/views/subscriptions/_loader.html.erb" lineno="52">
     <failure message="ClosingErbTagIndent: Remove newline before `%%&gt;` to match start of tag." type="ClosingErbTagIndent">
-      <![CDATA[app/views/subscriptions/_loader.html.erb:52:10]]>
+      <![CDATA[ClosingErbTagIndent: Remove newline before `%%>` to match start of tag. at app/views/subscriptions/_loader.html.erb:52:10]]>
     </failure>
   </testcase>
   <testcase name="app/views/application/index.html.erb" file="app/views/application/index.html.erb"/>