Skip to content

Commit

Permalink
inherit styleguide from gem instead of from config file
Browse files Browse the repository at this point in the history
this should make CI builds way more stable
  • Loading branch information
Philip Müller committed Aug 5, 2020
1 parent c83363c commit ec8a50b
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
inherit_from:
- https://shopify.github.io/ruby-style-guide/rubocop.yml
inherit_gem:
rubocop-shopify: rubocop.yml

AllCops:
TargetRubyVersion: 2.5
Expand Down
3 changes: 3 additions & 0 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@ GEM
rainbow (>= 2.2.2, < 4.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 1.4.0, < 1.7)
rubocop-shopify (1.0.0)
rubocop (>= 0.78.0)
ruby-progressbar (1.10.1)
smart_properties (1.15.0)
thread_safe (0.3.6)
Expand All @@ -97,6 +99,7 @@ DEPENDENCIES
rake
rspec
rubocop
rubocop-shopify

BUNDLED WITH
1.17.3
1 change: 1 addition & 0 deletions erb_lint.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,5 @@ Gem::Specification.new do |s|

s.add_development_dependency('rspec')
s.add_development_dependency('rubocop')
s.add_development_dependency('rubocop-shopify')
end

0 comments on commit ec8a50b

Please sign in to comment.