Support for rubocop 0.92 via rubocop-shopify #190
Conversation
v1.0.6 has explicit support for 0.92 which should be a good step towards rubocop 1.0.0 support which was released recently. https://github.com/Shopify/ruby-style-guide/releases/tag/v1.0.6 Support for rubocop 1.0.0 should land soon as well: Shopify/ruby-style-guide#207
|
I can reproduce the CI errors locally, but I'm not sure how to best resolve them. Using rubocop-shopify 1.0.4 which has support for rubocop 0.86 it seems to just not work properly. Is it a stated goal to keep supporting old rubocops? |
|
Any news about that? In our project we would like to update to rubocop v1, but we can't because of erb_lint still requires old rubocop versions. |
|
Trying to understand this. The version of rubocop is not locked in erb-lint (see https://github.com/Shopify/erb-lint/blob/540b88a9a79720930a62bdd2a05419a6b59d9e3d/erb_lint.gemspec#L29) so it should not be preventing you to upgrade. Do you mean that it is not working with the newest version or it is not allowing to install the latest version? |
|
Our CI is testing with Rubocop 1.10 already and it is passing. So I'm closing this PR. Thank you so much. |
v1.0.6 has explicit support for 0.92 which should be a good step towards
rubocop 1.0.0 support which was released recently.
https://github.com/Shopify/ruby-style-guide/releases/tag/v1.0.6
Support for rubocop 1.0.0 should land soon as well:
Shopify/ruby-style-guide#207