This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
Create Typescript namespace #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartogram
changed the title
GoodForOneFare
suggested changes
Aug 14, 2018
| @@ -0,0 +1,33 @@ | |||
| # Enforce pascal case when naming enums. (prefer-pascal-case-enums) | |||
There was a problem hiding this comment.
This should be a file rename. I still see docs/rules/prefer-pascal-case-enums.md.
There was a problem hiding this comment.
I like fully namespacing the rule name because I tend to copy+paste the names from here into package.json#eslintConfig.
So (shopify/typescript/prefer-pascal-case-enums) would be nice.
There was a problem hiding this comment.
Nit: Pascal is a noun, so pascal case => Pascal case 🤓
README.md
Outdated
| @@ -136,6 +134,8 @@ This plugin provides the following custom rules, which are included as appropria | |||
| - [sinon-no-restricted-features](docs/rules/sinon-no-restricted-features.md): Restrict the use of specified sinon features. | |||
| - [sinon-prefer-meaningful-assertions](docs/rules/sinon-prefer-meaningful-assertions.md): Require the use of meaningful sinon assertions through sinon.assert or sinon-chai. | |||
| - [strict-component-boundaries](docs/rules/strict-component-boundaries.md): Prevent module imports between components. | |||
| - [typescipt/prefer-pascal-case-enums](docs/rules/typescipt/prefer-pascal-case-enums.md): Prefer TypeScript enums be defined using pascal case. | |||
There was a problem hiding this comment.
Mention rule renames in CHANGELOG.
| @@ -0,0 +1,31 @@ | |||
| # Prefer singular TypeScript enums. (prefer-singular-enums) | |||
There was a problem hiding this comment.
(shopify/typescript/prefer-singular-enums)
There was a problem hiding this comment.
Should be a file rename. I'll stop mentioning that, now.
ismail-syed
approved these changes
Aug 14, 2018
cartogram
force-pushed
the
typescript-namespace
branch
from
eab32ae
to
8bf1930
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #136