expose blank event as a prop #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naqvitalha
commented
Feb 15, 2022
| * Please note that this event isn't synced with onScroll event but works with native onDraw/layoutSubviews. Events with values > 0 are blanks. | ||
| * This event is raised even when there is no visible blank with negative values for extensibility however, for most use cases check blankArea > 0 and use the value. | ||
| */ | ||
| onBlankArea: BlankAreaEventHandler; |
There was a problem hiding this comment.
Not adding event suffix to remain consistent with event naming
fortmarek
approved these changes
Feb 16, 2022
| @@ -25,13 +25,11 @@ class AutoLayoutViewManager: ReactViewManager() { | |||
| return AutoLayoutView(context).also { it.pixelDensity = context.resources.displayMetrics.density.toDouble() } | |||
| } | |||
|
|
|||
| override fun getExportedCustomBubblingEventTypeConstants(): Map<String, Any> { | |||
| override fun getExportedCustomDirectEventTypeConstants(): MutableMap<String, Any> { | |||
There was a problem hiding this comment.
why does this need to be MutableMap?
There was a problem hiding this comment.
It's just what base class specifies so I can't change it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was supposed to be very simple. Exposing blank area as a RFL prop. Once I did that I noticed the following problem
onBlankAreaEventfrom Performance wrapper is bubbled down to children leading to incorrect callback. I don't really see why we need to bubble events for these components so I changed to direct ones which are only limited to the component.ex. If we listen to this event on RFL events for the perf wrapper will also be passed to the RFL subscriber.
I've checked this both on Android/iOS
resolves #53 resolves #57