Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lists profiling #124

Merged
merged 1 commit into from Feb 23, 2022
Merged

Remove lists profiling #124

merged 1 commit into from Feb 23, 2022

Conversation

fortmarek
Copy link
Contributor

Fixes #89

What

Remove lists profiling code in favor of using @shopify/react-native-performance-lists-profiler library.

🎩

Check out the examples, see whether the events are still reported in the console (do not check the plugin, that will not work until a new release with this PR is released).

@caution-tape-bot
Copy link

👋 It looks like you're updating JavaScript packages that are known
to cause problems when duplicated.

You can deduplicate them with the yarn-deduplicate utility:

npx yarn-deduplicate --packages graphql react react-dom webpack
npx yarn-deduplicate --scopes @shopify @apollo

If running these commands doesn't produce a change in your yarn.lock file,
you didn't have duplications in these packages and can carry on.

A duplicate React version may cause an invalid hook call warning.

React context providers usually use module-scoped globals as their
default context values. Multiple versions of such packages will yield
multiple global instances, resulting in oblique runtime errors.

@ElviraBurchik
Copy link
Contributor

I realised that if we ever open-source this library, it won't contain profiling utils - they all belong to react-native-performance now. Not a blocker, just thinking out loud whether the package should come with utils if react-native-performance is not open-sourced

@fortmarek
Copy link
Contributor Author

Not a blocker, just thinking out loud whether the package should come with utils if react-native-performance is not open-sourced

That's a good point - before opensourcing this, we should look into how to make the profiling tools available to others. It also depends on how soon we will opensource this component compared to react-native-performance.

@fortmarek fortmarek merged commit 099a930 into main Feb 23, 2022
@fortmarek fortmarek deleted the remove-lists-profiler branch February 23, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flipper dependency breaks the app
2 participants