Flatlist API #4
Merged
Flatlist API #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RecyclerFlatList.tsx
Outdated
| horizontal: boolean; | ||
| } | ||
|
|
||
| class RFlatList extends React.PureComponent<RFlatListProps> { |
There was a problem hiding this comment.
Is it possible to use a component instead of a class? 👀
There was a problem hiding this comment.
I'd keep it a class since functional components inherit from React.Component instead of React.PureComponent. You could achieve the purity with some HoC or by implementing shouldComponentUpdate but that's not really worth it imho.
Additional resources: https://blog.logrocket.com/react-pure-components-functional/
naqvitalha
added a commit
that referenced
this pull request
Jul 5, 2022
* added experimental web support * Fixed inverted mode issue on web * updated known issues * added few tests * added sample for web * improved sample * removed local script * added height update logic * improved sample * fixed style issue * rephrase known issue * lint fix * updated e2e screenshot * fix broken e2e image * Added sample for CellRenderer and added support to disable autolayout * some updates to docs * Added render target support * data change won't rerender unless renderItem changes * added test * Fixed ref warning * review comments * review fixes * fixed script * build fix * added changelog * updated changelog * updated changelog * fixed type * Update CHANGELOG.md * lint fix Co-authored-by: Marek Fořt <marek.fort@shopify.com>
This was referenced Aug 25, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for using
RecyclerListViewwithFlatListAPI.