Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade RLV to 3.3.0-beta.2 #445

Merged
merged 3 commits into from
Jun 10, 2022
Merged

Upgrade RLV to 3.3.0-beta.2 #445

merged 3 commits into from
Jun 10, 2022

Conversation

naqvitalha
Copy link
Collaborator

@naqvitalha naqvitalha commented Jun 10, 2022

Description

Upgrading RLV to the latest version. Following changes are being included -

  • Started using suppressBoundedSizeException in FlashList. This will prevent crash if display:none is set on the list. This prop was added when Shopify mobile faced the problem. It wasn't enabled by us in order to observe if there'll be new instances of the crash in production.
  • Added ResizeObserver to web version of RLV. This is web only so cannot cause regression. There was no optimal way to observe size changes on web in the past due to which if element resize was done within the component RLV wouldn't know about it. To mitigate this devs used to call update on their own. After this change, no special handling will be needed. Huge win for dev ex. You can review the change here - Flipkart/recyclerlistview@8c8cddf

Checklist

@naqvitalha naqvitalha changed the title Upgrade RLV to 3.3.0-beta.1 Upgrade RLV to 3.3.0-beta.2 Jun 10, 2022
@naqvitalha naqvitalha enabled auto-merge (squash) June 10, 2022 10:34
@naqvitalha naqvitalha merged commit 1adfb47 into main Jun 10, 2022
@naqvitalha naqvitalha deleted the upgradeRLV-3.3.0 branch June 10, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants