Check for out of bound reads #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
fortmarek
reviewed
Jul 14, 2022
fortmarek
reviewed
Jul 15, 2022
This also gets rid of the dataLength variable
fortmarek
reviewed
Jul 15, 2022
src/FlashList.tsx
Outdated
Comment on lines
554
to
556
| if (trailingItem === undefined) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
Sorry fora yet-another change, I always find some small improvement 😄
This check should no longer be necessary since we ensure in the previous if that trailingItem exists
Suggested change
| if (trailingItem === undefined) { | |
| return null; | |
| } |
There was a problem hiding this comment.
No problem. Also fixed!
fortmarek
approved these changes
Jul 15, 2022
naqvitalha
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using a MobX store for the data a warning will be triggered from MobX about
out of bounds read (index). This is because the length of the array is not checked before accessing.This patch checks the length of the array before reading the value by index.
Checklist