Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose columnIndex and columnSpan to MasonryFlashList.renderItem #625

Merged
merged 3 commits into from
Oct 6, 2022

Conversation

jamesism
Copy link
Contributor

@jamesism jamesism commented Oct 5, 2022

Description

Adds an implicit columnIndex: number to extraData when using MasonryFlashList in order to expose which column information to the presentation layer.

Adds two new fields to the renderItem API for MasonryFlashList: columnIndex and columnSpan, such that consumers of MasonryFlashList are able to alter presentation based on the column in which they are rendered.

src/MasonryFlashList.tsx Outdated Show resolved Hide resolved
@jamesism jamesism changed the title Expose columnIndex to MasonryFlashList.renderItem via extraData. Expose columnIndex and columnSpan to MasonryFlashList.renderItem Oct 5, 2022
src/FlashListProps.ts Outdated Show resolved Hide resolved
src/MasonryFlashList.tsx Outdated Show resolved Hide resolved
… from root. Add some additional documentation
@jamesism jamesism marked this pull request as ready for review October 6, 2022 13:38
Copy link
Collaborator

@naqvitalha naqvitalha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naqvitalha naqvitalha merged commit 2a6bf8a into main Oct 6, 2022
@naqvitalha naqvitalha deleted the masonry-column-index branch October 6, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants