Change transform style on Android to fix perf #819
Conversation
naqvitalha
force-pushed
the
fix-android-inverted-performance
branch
from
a47ed5d
to
bb6c99c
Compare
| @@ -28,7 +28,7 @@ | |||
| "main": "dist/index.js", | |||
| "types": "dist/index.d.ts", | |||
| "scripts": { | |||
| "up": "bundle install && yarn fixture-up && yarn e2e-up && yarn build && yarn fixture-web-up", | |||
| "up": "bundle install && yarn fixture-up && yarn e2e-up && yarn build", | |||
There was a problem hiding this comment.
Removed due to some build issue. Not very important.
| @@ -2,6 +2,7 @@ import { BaseItemAnimator } from "recyclerlistview"; | |||
|
|
|||
| const PlatformConfig = { | |||
| defaultDrawDistance: 250, | |||
| invertedTransformStyle: { transform: [{ rotate: "180deg" }] }, | |||
There was a problem hiding this comment.
Only changing on Android as this doesn't impact other platforms. This also reduces testing footprint.
| @@ -2,6 +2,7 @@ import { BaseItemAnimator } from "recyclerlistview"; | |||
|
|
|||
| const PlatformConfig = { | |||
| defaultDrawDistance: 250, | |||
| invertedTransformStyle: { transform: [{ rotate: "180deg" }] }, | |||
There was a problem hiding this comment.
Maybe we can add a comment for why we're doing this and link to the original issues. Might be surprising to see this down the road.
|
Fixed the performance issue for me, so thanks a lot. Anyone else sees the same behavior? |
|
@KYZNCODE-Sebastian-Roese Indeed, the upstream react-native patch (facebook/react-native@3dd816c) suggests that we should pass |
Description
resolves #751
Change transform style to fix inverted performance issue on Android.
Reviewers’ hat-rack 🎩
Messages sample should perform flawlessly.
Checklist