sharding: Use InlineVerifier by default #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This functionality is superceded by the InlineVerifier. The tests fail without a IterativeVerifier hard coded into sharding.Ferry. It is not easy to retain these tests without major changes to deprecated features.
|
Oops I ran the wrong test suites locally and CI just failed on a real bug. Looks like the InlineVerifier is not playing nicely with the delta copier. I'll fix it and send another comment once I'm done. |
If all binlog events are filtered out by ApplicableEvents within the BinlogStreamer, an empty event list will be sent to the event listeners. This may be unexpected to the event listeners. To save the trouble, if the BinlogStreamer detects an empty binlog event list, it'll just not invoke the event listeners.
|
The issue was that the join table tests only inserts into joined tables, which are filtered out by the I'm ready for another review now. |
hkdsun
approved these changes
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that CompressionVerifierTest is removed from sharding/test. The CompressionVerifier is superceded by the InlineVerifier which has the features to verify compressed columns without a separate struct. The compression verifier tests rely on a hard coded IterativeVerifier on
sharding.Ferry. It would require major changes to deprecated functionality if we want to keep these tests, which is deprecated itself.Hopefully over the next while I can remove most of IterativeVerifier once we further validate the InlineVerifier.