avoid passing mysql serverID from copydb #273
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly passing a serverID in copydb config means only one copydb isntance can operate on a source mysql server at a time. This would be probably okay in a production environment, but for parallel testing where you have multiple copydb instance opearing on the same source mysql server can create an issue.
It's better to not explicitly pass a serverID from copydb and let the binlog_streamer generate a random serverID.