New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes mediumint not being recognized as number #298

Merged

shuhaowu merged 2 commits into Shopify:master from HemeraOne:293-mediumint-fix

Jul 12, 2021

Contributor

HemeraOne commented Jul 9, 2021

fixed #293


          Fixes mediumint not being recognized as number

1f0aa2e

Shopify#293

Contributor

shuhaowu commented Jul 12, 2021

Can you add a test similar to here: https://github.com/Shopify/ghostferry/blob/master/test/go/table_schema_cache_test.go#L87-L99


          added test to see if mediumint is accepted

Contributor Author

HemeraOne commented Jul 12, 2021

Done!

shuhaowu approved these changes

View reviewed changes

shuhaowu merged commit d7a3f61 into Shopify:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment