Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gotestsum arch checks #326

Merged
merged 1 commit into from
Jan 12, 2022
Merged

fix gotestsum arch checks #326

merged 1 commit into from
Jan 12, 2022

Conversation

shivnagarajan
Copy link
Contributor

This makes the download for gotestsum work on the various arch cases that we require (arm64 and x86_64)

Co-authored-by: Aaron Brady aaron.brady@shopify.com

Co-authored-by: Aaron Brady <aaron.brady@shopify.com>

Co-authored-by: Aaron Brady <aaron.brady@shopify.com>
Copy link
Contributor

@pawandubey pawandubey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aah, thank you. Much better than what I was trying to do 🙃

Copy link
Contributor

@insom insom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩 on a 64bit Pi, just in case:

raspberrypi:~/Repo/ghostferry$ make test
go version go1.15.9 linux/arm64
ulimit -n 1024 && ./bin/gotestsum --format short-verbose ./test/go ./copydb/test ./sharding/test -count 1 -p 1 -failfast

@shivnagarajan shivnagarajan merged commit ce94688 into master Jan 12, 2022
@shivnagarajan shivnagarajan deleted the fix_gotestsum_arch branch January 12, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants