Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build and release on arm64 #349

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Build and release on arm64 #349

merged 2 commits into from
Feb 13, 2024

Conversation

DazWorrall
Copy link
Member

@DazWorrall DazWorrall commented Feb 9, 2024 •
edited

Ref: https://github.com/Shopify/core-commerce-infra/issues/136

A few changes here to support multi-arch builds + releases:

  • Build the debs in the test workflow so they can be reviewed without needing a release
  • Update the build scripts to support multi-arch builds
  • Run the build jobs on both x86 and arm64
  • Build the shasum file in a separate step, when all of the files are available

DazWorrall
DazWorrall commented Feb 9, 2024
View reviewed changes
.github/workflows/build-deb.sh
# package.
DATETIME=$(date -u +%Y%m%d%H%M%S)
# package, and between different arch builds
DATETIME=$(date -u +%Y%m%d)
Copy link
Member Author

@DazWorrall DazWorrall Feb 9, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this so the filename patterns match between different arch builds. We don't need second-level precision here, especially when the filename include the short commit.

@DazWorrall DazWorrall changed the title Build and release on arm Build and release on arm64 Feb 9, 2024
@DazWorrall
Copy link
Member Author

You can see the build artifacts on the workflow summary page to check the results, e.g:

$ unzip -l debs-4624a3f9ee03fd1092b88683ad1ef4a328c5d90c.zip
Archive:  debs-4624a3f9ee03fd1092b88683ad1ef4a328c5d90c.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
      472  02-09-2024 13:35   ghostferry-4624a3f9ee03fd1092b88683ad1ef4a328c5d90c.sha256sum
  6162532  02-09-2024 13:35   ghostferry-copydb_1.1.0+20240209+4624a3f_amd64.deb
  5734716  02-09-2024 13:35   ghostferry-copydb_1.1.0+20240209+4624a3f_arm64.deb
  6248788  02-09-2024 13:35   ghostferry-sharding_1.1.0+20240209+4624a3f_amd64.deb
  5824666  02-09-2024 13:35   ghostferry-sharding_1.1.0+20240209+4624a3f_arm64.deb
---------                     -------
 23971174                     5 files

@DazWorrall DazWorrall marked this pull request as ready for review February 9, 2024 14:01
@DazWorrall DazWorrall requested a review from a team February 9, 2024 14:02
@DazWorrall DazWorrall merged commit 4b80da7 into main Feb 13, 2024
10 checks passed
@DazWorrall DazWorrall deleted the build-and-release-on-arm branch February 13, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driv3r driv3r driv3r approved these changes

Assignees
No one assigned
Labels
#gsd:39331
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DazWorrall @driv3r