Allow CopyDB to run on a read only replica #35
Conversation
shuhaowu
force-pushed
the
copydb-integration
branch
3 times, most recently
from
1a8f533
to
43e5f6b
Compare
| r.logger.WithField("error", err).Errorf("could not open connection to master replica") | ||
| r.Ferry.ErrorHandler.Fatal("sharding", err) | ||
| } | ||
| } |
There was a problem hiding this comment.
The reason this was here is that we pt-kill idle connections on the db. So, if we open the connection too soon it might get killed by the server by the time we need it.
There was a problem hiding this comment.
I thought the Go driver reconnect automatically?
Simplifies the logger passing in a little bit as nowhere else use these methods.
shuhaowu
force-pushed
the
copydb-integration
branch
from
c513b58
to
fc57718
Compare
|
Can I get a review on this PR soon? |
- Use two example configurations - Fixed import alias typo
|
I'm merging this for now as agreed upon for now so we can unblock further work. |
|
https://shopify.github.io/ghostferry/master/copydbinprod.html#prerequisites
Maybe the document should be updated? |
This refactored the sanity check logic for the replication config into
ghostferry.Ferryso that both sharding and copydb can benefit from it. This PR also adds the necessary configuration to copydb to allow it to run off of a read only replica.I've also updated the local docker-compose setup to three nodes so people can test it easily with the example config.