Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require active_support before extensions #22

Merged
merged 2 commits into from
Dec 21, 2021
Merged

Require active_support before extensions #22

merged 2 commits into from
Dec 21, 2021

Conversation

timothysmith0609
Copy link
Contributor

Activesupport 7 is breaking due to failure to load transitive dependency in a submodule. This issue outlines the need to require the base active_support before including other extensions.

@lmunro-at-shopify
Copy link

Perhaps we should consider incrementing the version to 1.0.2 then?

lmunro-at-shopify
lmunro-at-shopify reviewed Dec 21, 2021
View reviewed changes
Copy link

@lmunro-at-shopify lmunro-at-shopify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with version incremented).

@timothysmith0609 timothysmith0609 merged commit 8730afd into master Dec 21, 2021
@timothysmith0609 timothysmith0609 deleted the require_activesupport_before_extensions branch December 21, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmunro-at-shopify lmunro-at-shopify lmunro-at-shopify left review comments

@ChrisBr ChrisBr ChrisBr approved these changes

@DazWorrall DazWorrall Awaiting requested review from DazWorrall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timothysmith0609 @lmunro-at-shopify @ChrisBr