Skip to content

Commit

Permalink
Merge pull request #94 from Shopify/remove-deprecated-execution-strategy
Browse files Browse the repository at this point in the history
Remove deprecated execution strategies
  • Loading branch information
swalkinshaw committed Feb 4, 2019
2 parents d1244b7 + 7a59166 commit 4d0a933
Show file tree
Hide file tree
Showing 6 changed files with 3 additions and 120 deletions.
3 changes: 2 additions & 1 deletion .travis.yml
Expand Up @@ -4,4 +4,5 @@ rvm:
- 2.2
- 2.3
- 2.4
before_install: gem install bundler -v 1.13.3
- 2.5
- 2.6
3 changes: 1 addition & 2 deletions graphql-batch.gemspec
Expand Up @@ -18,13 +18,12 @@ Gem::Specification.new do |spec|
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
spec.require_paths = ["lib"]

spec.add_runtime_dependency "graphql", ">= 0.8", "< 2"
spec.add_runtime_dependency "graphql", ">= 1.3", "< 2"
spec.add_runtime_dependency "promise.rb", "~> 0.7.2"

if RUBY_ENGINE == 'ruby' && Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("2.2")
spec.add_development_dependency "byebug"
end
spec.add_development_dependency "bundler", "~> 1.10"
spec.add_development_dependency "rake", "~> 10.0"
spec.add_development_dependency "minitest"
end
6 changes: 0 additions & 6 deletions lib/graphql/batch.rb
@@ -1,7 +1,4 @@
require "graphql"
if Gem::Version.new(GraphQL::VERSION) < Gem::Version.new("1.3")
warn "graphql gem versions less than 1.3 are deprecated for use with graphql-batch, upgrade so lazy_resolve can be used"
end
require "promise.rb"

module GraphQL
Expand Down Expand Up @@ -31,9 +28,6 @@ def self.use(schema_defn, executor_class: GraphQL::Batch::Executor)
end
schema_defn.lazy_resolve(::Promise, :sync)
end

autoload :ExecutionStrategy, 'graphql/batch/execution_strategy'
autoload :MutationExecutionStrategy, 'graphql/batch/mutation_execution_strategy'
end
end

Expand Down
67 changes: 0 additions & 67 deletions lib/graphql/batch/execution_strategy.rb

This file was deleted.

23 changes: 0 additions & 23 deletions lib/graphql/batch/mutation_execution_strategy.rb

This file was deleted.

21 changes: 0 additions & 21 deletions test/execution_strategy_test.rb

This file was deleted.

0 comments on commit 4d0a933

Please sign in to comment.