Updated interface support #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccajfriedman
force-pushed
the
updated_interface_support
branch
from
70e28e0
to
f93a7d2
Compare
melissaluu
reviewed
Mar 6, 2019
src/decode.js
Outdated
| @@ -116,11 +116,13 @@ function transformScalars(context, value) { | |||
| } | |||
|
|
|||
| function recordTypeInformation(context, value) { | |||
| const selectionSet = context.selection.selectionSet; | |||
There was a problem hiding this comment.
Just for reference, you can also destructure the context.selection.selectionSet like this:
const {typeBundle, typeSchema} = context.selection.selectionSet;
This way you can directly use the typeBundle and typeSchema constants afterwards.
minasmart
reviewed
Mar 6, 2019
test/schema-type-test.js
Outdated
| @@ -3,6 +3,7 @@ import typeBundle from '../fixtures/custom-type-bundle'; | |||
| import schemaForType from '../src/schema-for-type'; | |||
| import Query from '../src/query'; | |||
| import Mutation from '../src/mutation'; | |||
| import realTypeBundle from '../fixtures/types'; // eslint-disable-line import/no-unresolved | |||
There was a problem hiding this comment.
I'm unsure about the naming here. It may be better to call typeBundle customTypeBundleand this onetypeBundleor something.realTypeBundle` just raises all sorts of questions about what the other bundle is.
There was a problem hiding this comment.
You're completely right. I will rename this.
minasmart
approved these changes
Mar 6, 2019
jmignac
approved these changes
Mar 6, 2019
rebeccajfriedman
force-pushed
the
updated_interface_support
branch
from
57f8842
to
83d8164
Compare
rebeccajfriedman
force-pushed
the
updated_interface_support
branch
from
83d8164
to
6674a46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for falling back when interface objects can't be translated.
Relates to Shopify/js-buy-sdk#614
I'm trying to fix the situation in the linked issue, which is outlined below:
DiscountApplication)AutomaticDiscountApplication)AutomaticDiscountApplicationobjects to an old version of the client, which does not have a definition for it in the schema. Instead of failing silently / falling back, the queryreturns an error.