Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup execution order workarounds #49

Closed
swalkinshaw opened this issue Mar 29, 2021 · 0 comments
Closed

Cleanup execution order workarounds #49

swalkinshaw opened this issue Mar 29, 2021 · 0 comments
Labels

Comments

@swalkinshaw
Copy link
Contributor

Until rmosolgo/graphql-ruby#3393, execute_multiplex wasn't guaranteed to be run first in all situations which mean we needed workarounds like

def capture_parsing_time
# GraphQL::Query#result fires `parse` before the `execute_multiplex` event, so sometimes
# `pre_context.multiplex_start_time_monotonic` isn't set.
parsing_offset_time = pre_context.multiplex_start_time_monotonic || GraphQL::Metrics.current_time_monotonic
timed_result = GraphQL::Metrics.time(parsing_offset_time) { yield }

Once rmosolgo/graphql-ruby#3393 is released in a version, we could eventually bump our requirement and remove these workarounds. In the meantime, #48 clarifies documentation at least.

@gmac gmac closed this as completed Dec 6, 2023
@gmac gmac reopened this Dec 6, 2023
@gmac gmac closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants