Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify tracer execution order #48

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Clarify tracer execution order #48

merged 1 commit into from
Mar 29, 2021

Conversation

eapache
Copy link
Contributor

@eapache eapache commented Mar 29, 2021

Since rmosolgo/graphql-ruby#3393 it should at
least be consistent.

Since rmosolgo/graphql-ruby#3393 it should at
least be consistent.
@eapache eapache self-assigned this Mar 29, 2021
@swalkinshaw
Copy link
Contributor

def capture_parsing_time
# GraphQL::Query#result fires `parse` before the `execute_multiplex` event, so sometimes
# `pre_context.multiplex_start_time_monotonic` isn't set.
parsing_offset_time = pre_context.multiplex_start_time_monotonic || GraphQL::Metrics.current_time_monotonic
timed_result = GraphQL::Metrics.time(parsing_offset_time) { yield }

This could be removed at some point if we required the new graphql version right?

@eapache
Copy link
Contributor Author

eapache commented Mar 29, 2021

🤔 yes, though the upstream PR isn't even in a cut version yet. File an issue on this repo to remind us?

@swalkinshaw
Copy link
Contributor

Sure, done in #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants