Fix skip_tracing compatibility #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swalkinshaw
force-pushed
the
fix-skip-tracing-compatibility
branch
3 times, most recently
from
2d61b78
to
a2ce16c
Compare
swalkinshaw
force-pushed
the
fix-skip-tracing-compatibility
branch
from
a2ce16c
to
a5909d8
Compare
toneymathews
approved these changes
Apr 11, 2023
`Trace#initialize` was incorrectly assuming that a `@Query` or `@multiplex` was always defined. However, tracers can be instantiated manually outside of a Query context (at least to start with).
swalkinshaw
force-pushed
the
fix-skip-tracing-compatibility
branch
from
a5909d8
to
f7ad833
Compare
toneymathews
approved these changes
Apr 12, 2023
rmosolgo
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trace#initializewas incorrectly assuming that a@Queryor@multiplexwas always defined. However, tracers can be instantiated manually outside of a Query context (at least to start with).