Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] ProductProvider requires metafields when it should not #1127

Closed
jplhomer opened this issue Apr 25, 2022 · 0 comments · Fixed by #1209 or #1205
Closed

[BUG] ProductProvider requires metafields when it should not #1127

jplhomer opened this issue Apr 25, 2022 · 0 comments · Fixed by #1209 or #1205
Assignees
@blittle
Labels
bug Something isn't working hydrogen-ui Components, hooks, and utilities
Milestone
GA

Comments

@jplhomer
Copy link
Contributor

Describe the bug
If you use ProductProvider but don't query for metafields, an error is thrown.

To Reproduce
https://stackblitz.com/edit/shopify-hydrogen-n81vep?file=src%2Fcomponents%2FProductDetails.client.jsx&title=Hydrogen

Expected behaviour
You should be able to use ProductProvider without metafields.

Additional context
Add any other context about the problem here. eg.

  • Hydrogen version: v0.16.1
@jplhomer jplhomer added bug Something isn't working hydrogen-ui Components, hooks, and utilities labels Apr 25, 2022
@elisenyang elisenyang added this to the GA milestone Apr 29, 2022
@blittle blittle self-assigned this May 5, 2022
blittle added a commit that referenced this issue May 5, 2022
@blittle
Make metafields optional within the ProductProvider. Fixes #1127
817dcd8
@blittle blittle mentioned this issue May 5, 2022
Merged
blittle added a commit that referenced this issue May 5, 2022
@blittle
Make metafields optional within the ProductProvider. Fixes #1127 (#1209)
d0dada0
@github-actions github-actions bot mentioned this issue May 5, 2022
Merged
blittle added a commit that referenced this issue May 9, 2022
@blittle
Merge branch 'v1.x-2022-07' into bl-countries-session
c11637f 
* v1.x-2022-07:
  Fix stale product options (#1210)
  Upgrade body-parser in hydrogen package (#1232)
  Add new options to Money and useMoney (#1215)
  fix links (#1229)
  Update turbo and instructions for developing `dev` (#1225)
  Heck - deploy all branches to Oxygen
  add context for initialvariantid (#1217)
  Build chunks are inside assets folder (#1211)
  Upgraded to SFAPI 2022-07 (#1214)
  [ci] release v1.x-2022-07 (#1205)
  Make this a patch instead of minor
  add references to video in file_reference block (#1197)
  Laying the foundation for building components in isolation (#1188)
  Make metafields optional within the ProductProvider. Fixes #1127 (#1209)
  Add README to /templates directory (#1163)
  fix perf tracking and make it optional from developer's end (#1096)
  docs fixes (#1204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blittle blittle

Labels
bug Something isn't working hydrogen-ui Components, hooks, and utilities
Projects
None yet
Milestone
GA
3 participants
@jplhomer @blittle @elisenyang