externalize jsx-runtime and get it working in the dev package #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frandiox
reviewed
Apr 13, 2022
| @@ -6,7 +6,7 @@ import shopifyConfig from './shopify.config'; | |||
| // https://vitejs.dev/config/ | |||
| export default defineConfig({ | |||
| plugins: [hydrogen(shopifyConfig)], | |||
| optimizeDeps: {include: ['@headlessui/react']}, | |||
| optimizeDeps: {include: ['@headlessui/react', 'react/jsx-runtime']}, | |||
There was a problem hiding this comment.
Can we add this in the Hydrogen plugin directly? Just so we don't bother users with upstream workarounds.
|
We detected some changes in |
|
Updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, we were creating a local version of the jsx-runtime file in the hydrogen-ui package: here's some screenshots showing the local import and the dist folder after building:
However, I believe the jsx-runtime library should be found during the app's buildtime (not hydrogen-ui's buildtime), so we want to externalize it. In doing so, there appears to be an issue with Vite's built-in React plugin, so we need to help it out by adding it to the
optimizeDepsarray. So I documented that as well.For reference, here's what it looks like after these change:
Looks better!