Powered by update #2516
Powered by update #2516
Conversation
|
We detected some changes in |
| @@ -136,7 +136,7 @@ export const renderHydrogen = (App: any) => { | |||
|
|
|||
| if (hydrogenConfig.poweredByHeader ?? true) { | |||
| // If undefined in the config, then always show the header | |||
| response.headers.set('powered-by', 'Shopify-Hydrogen'); | |||
| response.headers.set('powered-by', 'Shopify, Hydrogen'); | |||
There was a problem hiding this comment.
We only have hydrogen in v2, should we keep it that way here too?
There was a problem hiding this comment.
@blittle -- we should have Shopify, Hydrogen in both -- and then up to Oxygen to simply append 'Oxygen'
There was a problem hiding this comment.
@benjaminsehl nope, Oxygen specifically asked for it to be Hydrogen, and they append the other two.
There was a problem hiding this comment.
@blittle -- OK. But off Oxygen then it will only be Hydrogen?
This ___________, so I am just trying to follow what his original request was that JS linked to (which didn't even mention Oxygen).
There was a problem hiding this comment.
There was a problem hiding this comment.
I thought I was explicit about this when they implemented it, I thought it was weird for us to only do Hydrogen, but the consensus was we just do "Hydrogen". See their implementation here: https://github.com/Shopify/oxygen-workers/pull/853/files#diff-bbe56b6f30db247b956e162af183823b1e5c916d0b9518648fd5ee73a98b3f49R131
There was a problem hiding this comment.
So if we do both here, we need to update H2 as well, because it only sets powered-by: Hydrogen
Updates
powered-byheader to use current syntax