Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add script to patch React experimental #514

Closed
wants to merge 2 commits into from

Conversation

frandiox
Copy link
Contributor

@frandiox frandiox commented Jan 24, 2022

Description

Closes #512

This adds a dirty patch with the changes in facebook/react#23171

@jplhomer Do you think we should include this? Or just release with the bug until React team merges the PR?

It runs whenever Vite runs, which I think is safer than postinstall.


Before submitting the PR, please make sure you do the following:

  • Add your change under the Unreleased heading in the package's CHANGELOG.md
  • Read the Contributing Guidelines
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123)
  • Update docs in this repository for your change, if needed

@jplhomer
Copy link
Contributor

Closing in favor of Shopify/hydrogen#521 🎉

@jplhomer jplhomer closed this Jan 24, 2022
@jplhomer jplhomer deleted the fd-react-fizz-patch branch January 24, 2022 18:31
rafaelstz pushed a commit to rafaelstz/hydrogen that referenced this pull request Mar 4, 2023
* Avoid waterfall errors when initial build fails

* Changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] TypeError: Cannot read properties of undefined (reading 'add')
2 participants