fix type for withCache (#1363)

Shopify · Sep 25, 2023 · 1be1e40 · 1be1e40
1 parent 425791c
commit 1be1e40
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/gentle-steaks-shave.md b/.changeset/gentle-steaks-shave.md
@@ -0,0 +1,5 @@
+---
+'@shopify/hydrogen': patch
+---
+
+Allow generic inference in standalone usage of WithCache type - Contributed by @chinanderm
diff --git a/packages/hydrogen/src/with-cache.ts b/packages/hydrogen/src/with-cache.ts
@@ -37,10 +37,10 @@ export function createWithCache<T = unknown>(
  *
  * Use the `CachingStrategy` to define a custom caching mechanism for your data. Or use one of the built-in caching strategies: `CacheNone`, `CacheShort`, `CacheLong`.
  */
-type CreateWithCacheReturn<T> = (
+type CreateWithCacheReturn<T> = <U = T>(
   cacheKey: CacheKey,
   strategy: CachingStrategy,
-  actionFn: () => T | Promise<T>,
-) => Promise<T>;
+  actionFn: () => U | Promise<U>,
+) => Promise<U>;
 
 export type WithCache = ReturnType<typeof createWithCache>;