Skip to content

Commit

Permalink
Fix package dependencies (#1489)
Browse files Browse the repository at this point in the history
* Remove unused deps from mini-oxygen

* Remove peerDeps from cli that are only used in virtual routes

* Do not import from remix-oxygen in virtual-routes

* Do not mark server-runtime as optional peerDep in remix-oxygen

* Do not mark remix deps as optional peerDeps in hydrogen

* Update package-lock

* Add server-runtime as a dependency in user projects

* Changesets

* Changesets

* Change Hydrogen dependency in templates
  • Loading branch information
frandiox committed Nov 7, 2023
1 parent e8cc49f commit 8fce70d
Show file tree
Hide file tree
Showing 14 changed files with 111 additions and 312 deletions.
8 changes: 8 additions & 0 deletions .changeset/spicy-cobras-sniff.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
'@shopify/remix-oxygen': patch
'@shopify/mini-oxygen': patch
'@shopify/hydrogen': patch
'@shopify/cli-hydrogen': patch
---

Fix peer dependencies across packages.
13 changes: 13 additions & 0 deletions .changeset/tiny-donkeys-suffer.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---
'skeleton': patch
---

Since Remix is now a peer dependency of `@shopify/remix-oxygen`, you need to add `@remix-run/server-runtime` to your dependencies with the same version you have for the rest of Remix dependencies.

```diff
"dependencies": {
"@remix-run/react": "2.1.0"
+ "@remix-run/server-runtime": "2.1.0"
...
}
```
1 change: 1 addition & 0 deletions examples/customer-api/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"prettier": "@shopify/prettier-config",
"dependencies": {
"@remix-run/react": "2.1.0",
"@remix-run/server-runtime": "2.1.0",
"@shopify/cli": "3.50.0",
"@shopify/cli-hydrogen": "^6.0.0",
"@shopify/hydrogen": "^2023.10.0",
Expand Down
1 change: 1 addition & 0 deletions examples/express/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"@remix-run/express": "2.1.0",
"@remix-run/node": "2.1.0",
"@remix-run/react": "2.1.0",
"@remix-run/server-runtime": "2.1.0",
"@shopify/hydrogen": "2023.10.2",
"compression": "^1.7.4",
"cross-env": "^7.0.3",
Expand Down
Loading

0 comments on commit 8fce70d

Please sign in to comment.