Throw when storeDomain is missing in production (#1979)

* Throw when storeDomain is missing in production * Changesets * Fix log enhancer after changing message
Shopify · Apr 11, 2024 · dcabe91 · dcabe91
1 parent 42d3c60
commit dcabe91
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 4 deletions.
diff --git a/.changeset/spicy-lemons-impress.md b/.changeset/spicy-lemons-impress.md
@@ -3,4 +3,4 @@
 '@shopify/hydrogen': patch
 ---
 
-Fall back to "mock.shop" when no value is passed in `storeDomain` to `createStorefrontClient`.
+Fall back to "mock.shop" when no value is passed in `storeDomain` to `createStorefrontClient` in development.
diff --git a/packages/cli/src/lib/log.ts b/packages/cli/src/lib/log.ts
@@ -344,7 +344,7 @@ export function enhanceH2Logs(options: {
 
       if (
         stringArg.startsWith('[h2:info:createStorefrontClient]') &&
-        stringArg.includes('"mock.shop"')
+        stringArg.includes('defaulting to mock.shop')
       ) {
         // This message comes from hydrogen-react. Let's enhance it:
         stringArg += '\nRun `h2 link` to link your store.';

diff --git a/packages/hydrogen-react/src/storefront-client.ts b/packages/hydrogen-react/src/storefront-client.ts
@@ -34,8 +34,18 @@ export function createStorefrontClient({
   contentType,
 }: StorefrontClientProps): StorefrontClientReturn {
   if (!storeDomain) {
-    storeDomain = MOCK_SHOP_DOMAIN;
-    warnOnce(`storeDomain missing, defaulting to ${MOCK_SHOP_DOMAIN}`, 'info');
+    if (__HYDROGEN_DEV__) {
+      storeDomain = MOCK_SHOP_DOMAIN;
+      warnOnce(
+        `storeDomain missing, defaulting to ${MOCK_SHOP_DOMAIN}`,
+        'info',
+      );
+    } else {
+      throw new Error(
+        H2_PREFIX_ERROR +
+          `\`storeDomain\` is required when creating a new Storefront client in production.`,
+      );
+    }
   }
 
   if (storefrontApiVersion !== SFAPI_VERSION) {