underscore _ attribute?

[jamalsoueidan]

<div className="grid pb-2">
  {(attributes || []).map(({key, value}) => (
    <Text color="subtle" key={key}>
      {key}: {value}
    </Text>
  ))}
</div>

Should we hide the underscore attributes? I think this is done in most themes, and is maybe shopify rule, so we just need to filter out the keys that start with underscore. If it's just that I could add that.

[frehner]

Sorry, I'm having a hard time understanding the proposal here. Can you clarify what you mean? Where are attributes coming from?

[jamalsoueidan]

https://www.506.io/easygift-doc/prevent-hidden-line-item-properties-showing-in-your-theme-gifted

[juanpprieto]

The checkout automatically hides cart line item attributes when the attribute key is prefixed with _.

Personally, I think in a headless environment developers should have full control to decide wether to render or not any of the cart line item attributes regardless of the _ prefix.

[jamalsoueidan]

If checkout automatically hides cart line items that are prefixed with underscore, and same goes for themes, then we should follow the same pattern all the way. In case developer want to show them, they just need to remove the filter.

[jamalsoueidan]

I just notice that we also doesn't render lineItem attributes on the order page for the account (customer).
We need to add that. Or else we have lineItem some place and other places we hide them,